atheme
atheme copied to clipboard
include IP, not just rDNS, in SASL failure snotes
if you want to automate banning things that are doing a lot of SASL failures, rDNSes with multiple A/AAAA records make it impossible to know which IP is actually doing it. you could ban them all, but that would let people add IPs they do not own to their domains and get those banned too, so you'd want to PTR resolve them manually. makes more sense to tell us what IP was doing it
perhaps we could just use IP and not rDNS at all?
anyway this is the bit of code that matters https://github.com/atheme/atheme/blob/40303d63ba65283b1cd84d8e076a0b37b79e2f3c/modules/saslserv/main.c#L94
perhaps we could just use IP and not rDNS at all?
+1 - Given that the only effective bans on SASL bruteforcers generally take effect before rDNS lookup, we don’t even really need to know the rDNS at all for this purpose