gijgo icon indicating copy to clipboard operation
gijgo copied to clipboard

TimePicker ampm mode, 12pm

Open banders opened this issue 5 years ago • 1 comments

The timepicker has some incorrect behavior in ampm mode when the selected hour is 12. Here's how to reproduce the problem

  • initialize the timepicker in ampm mode with an initial time in the am (say 9:00am)
  • open the clock (it will correctly show the selected time is 9:00am)
  • now select hour 12 on the clock (the clock will show hour 12 is selected. the header will show pm is selected).
  • click ok (the clock closes and the time set in the text field is 00:00 am)

There are two problems here: First, the hour in the text field should be shown as 12, not 00. Second, the "am" in the text box is not consistent with the "pm" that was shown on the clock.

banders avatar Sep 26 '20 21:09 banders

@atatanasov See pull request for a proposed patch

banders avatar Sep 26 '20 23:09 banders