webapis-playground icon indicating copy to clipboard operation
webapis-playground copied to clipboard

OG Image: updated _app.tsx

Open jjung99 opened this issue 4 years ago • 15 comments

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # 25

Type of change

Please delete options that are not relevant.

  • [x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

It has been tested by the visual studio for compilation and preview URL through PR for output

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Checklist:

  • [ ] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [x] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests pass locally with my changes
  • [ ] Any dependent changes have been merged and published in downstream modules

jjung99 avatar Oct 18 '21 09:10 jjung99

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/thoughtdump/webapis-playground/FN8spgbodDQLr7tmSZUZC2zK6HTT
✅ Preview: https://webapis-playground-git-fork-jjung99-issue-25-300ed0-thoughtdump.vercel.app

vercel[bot] avatar Oct 18 '21 09:10 vercel[bot]

Hi, I only changed one file which is _app.tsx file and added few lines in it for facebook OG image. I just tested it and it worked! testPng

jjung99 avatar Oct 18 '21 09:10 jjung99

@jjung99 Great,

Could you please summarize it with the list of platforms you have tested and found to be working with the latest code? Screenshots of them would be great.

  • [x] Twitter
  • [ ] LinkedIn
  • [x] Reddit
  • [x] Facebook

atapas avatar Oct 18 '21 09:10 atapas

Platforms for testing with screenshot

  • Twitter twitter test

  • LinkedIn linkedin test

  • Reddit reddit test

  • Facebook facebook test

jjung99 avatar Oct 18 '21 10:10 jjung99

Platforms for testing with screenshot

  • Twitter twitter test
  • LinkedIn linkedin test
  • Reddit reddit test
  • Facebook facebook test

So it is mostly fixed except LinkedIn where it shows @max-programming's DP 😂. Can we fix that too?

atapas avatar Oct 18 '21 10:10 atapas

I will try to fix it within today! lol

jjung99 avatar Oct 18 '21 10:10 jjung99

I think I'm famous 😂

max-programming avatar Oct 19 '21 16:10 max-programming

I will try to fix it within today! lol

@jjung99 is it done?

atapas avatar Oct 20 '21 04:10 atapas

The way the LinkedIn brings og image is different I think. I actually have midterms tomorrow so Can you give me couple of extra days?

jjung99 avatar Oct 20 '21 04:10 jjung99

The way the LinkedIn brings og image is different I think. I actually have midterms tomorrow so Can you give me couple of extra days?

Yeah plz, take your time.. Just let me know when ready!

atapas avatar Oct 20 '21 05:10 atapas

Thanks for understanding. I will start to work on it as soon as the tests are done!

jjung99 avatar Oct 20 '21 05:10 jjung99

Please I need to update my ogwhatsapp

Michae645j avatar Oct 23 '21 23:10 Michae645j

Screenshot_20211023-225740_OGWhatsApp

Michae645j avatar Oct 23 '21 23:10 Michae645j

Hey @jjung99 Any update?

atapas avatar Oct 27 '21 15:10 atapas

@jjung99 would you make any further changes to it?

atapas avatar Nov 23 '21 08:11 atapas