angular-eonasdan-datetimepicker icon indicating copy to clipboard operation
angular-eonasdan-datetimepicker copied to clipboard

Published 20 hours ago • verified publisher icon atais

get rid of jQuery usage

Open frostbolt opened this issue 6 years ago • 9 comments

Hi.

Your plugin depends on outdated jQuery version, that is no longer maintained At first I was going to move it to third jQuery but then I noticed that there's only one jQuery call that can be easily replaced with native code.

As you can see here, native .map realization is compatible with all modern (IE9+) browsers.

frostbolt avatar Apr 11 '19 09:04 frostbolt

dude the eonasdan-datetimepicker uses jQuery. this is just a wrapper.

you will need jQuery anyway to run the library.

atais avatar Apr 11 '19 09:04 atais

yeah, but it uses jquery itself. your implementation requires an outdated 2nd version, which has security vulnerabilities, according to npm audit.

It's required to get rid of it's usage or update the dependency.

frostbolt avatar Apr 11 '19 11:04 frostbolt

Sorry I did not have time to merge it however, i do not know why but travis is not showing up here. But your changes fail on tests: https://travis-ci.org/atais/angular-eonasdan-datetimepicker

if you fix it I can merge the change. I think fixing the dependency is easier

atais avatar Apr 14 '19 18:04 atais

@frostbolt now travis works

atais avatar Apr 24 '19 13:04 atais

@atais I'll take a look later this month.

frostbolt avatar Apr 24 '19 15:04 frostbolt

Hi, @atais, Actually I found an issue in my code 🌚 , but tests still doesn't work.

When I try to run them it seems like angularjs doesn't work. I can see {{expressions}} inside the page.

But the most strange thing is that I've managed to run them manually running npm start. Looks like everything is just fine. image

PS. I've tried to run the tests for origin/master. Unsuccessfully.

frostbolt avatar Apr 30 '19 20:04 frostbolt

Damn it happens from time to time because I don't update the dependencies and the tests have to be fixed. I am currently on holidays but I will try to fix it once I am back

atais avatar May 01 '19 13:05 atais

I noticed that I've accidentally moved several dependencies from dev to common section. Fixed that.

I've also replaced ' with \" as long as 1st variant causing error on windows platform (see screenshot below). image

frostbolt avatar May 07 '19 14:05 frostbolt

I have just looked into it, but it does not seem easy. I do not know why it stopped working and what is the cause.

To be honest, I am not working with those technologies anymore so I really do not want to step into it.

If you want and could fix the tests I will gladly merge the changes.

atais avatar May 21 '19 14:05 atais