studio icon indicating copy to clipboard operation
studio copied to clipboard

Misalignment of Code Editor Highlight Box

Open princerajpoot20 opened this issue 2 years ago • 11 comments

Problem

Screenshot 2023-11-25 at 12 57 09 PM

The highlight box for the code editor mode in the EditorSwitch component is not centered and spills out of the boundary.

Viewing the Issue

See it here: Link

Expectation

It should be perfectly aligned.

princerajpoot20 avatar Nov 25 '23 09:11 princerajpoot20

/gfi ts

princerajpoot20 avatar Nov 28 '23 18:11 princerajpoot20

@princerajpoot20 In which environment is it not centred? I tried it on Chrome, Firefox and Sarafi. it is centred for me. 🤔

KhudaDad414 avatar Nov 30 '23 10:11 KhudaDad414

@KhudaDad414 In Chrome on my system, it is not centered. In Safari, it is centered correctly, but the inner symbol are not visible. In Brave, it is displayed perfectly.

Chrome: Screenshot 2023-11-30 at 9 55 04 PM Safari: Screenshot 2023-11-30 at 10 03 34 PM Brave: Screenshot 2023-11-30 at 10 04 17 PM

princerajpoot20 avatar Nov 30 '23 16:11 princerajpoot20

For chrome, it is perfectly aligned: image

I think the issue has been resolved.

adityagarg06 avatar Feb 23 '24 11:02 adityagarg06

Screenshot (179)

On Chrome and Opera browsers it is perfectly aligned. There is no issue with the alignment of the highlight box. Issue Resolved.

nikhil-3112 avatar Feb 24 '24 10:02 nikhil-3112

@princerajpoot20 you still see this issue ?

Amzani avatar Feb 26 '24 09:02 Amzani

@Amzani Yes, the issue is still there. Link used in the browser: https://deploy-preview-978--asyncapi-studio-design-system.netlify.app/?path=/story/components-editorswitch--c

https://github.com/asyncapi/studio/assets/44585452/03db918b-eb3b-4456-a4fc-bce8f3a06637

princerajpoot20 avatar Feb 27 '24 13:02 princerajpoot20

@princerajpoot20 since I can't reproduce it on my environment (tried with 3 browsers and it's centred.) can you open a PR with a fix?

KhudaDad414 avatar Mar 05 '24 12:03 KhudaDad414

@KhudaDad414 Sure.

princerajpoot20 avatar Mar 05 '24 18:03 princerajpoot20

@princerajpoot20 could it be that your chrome version is not updated? (Just a thought) browsers make all kinds of mistakes.

lmgyuan avatar Mar 20 '24 03:03 lmgyuan

This issue has been automatically marked as stale because it has not had recent activity :sleeping:

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience :heart:

github-actions[bot] avatar Jul 19 '24 04:07 github-actions[bot]