generator icon indicating copy to clipboard operation
generator copied to clipboard

Published 20 hours ago • verified publisher icon asyncapi

Refactoring of props for ClientClass in python template

Open Adi-204 opened this issue 6 months ago • 6 comments

currently inside client.py.js of python websocket client we have a component ClientClass which passes all the props down to respective components. This list can grow in future and hard to manage, their is potential of refactoring this code and passing complete asyncapi object and extracting from it in their respective components.

Ref - https://github.com/asyncapi/generator/blob/master/packages/templates/clients/websocket/python/template/client.py.js

Adi-204 avatar May 19 '25 08:05 Adi-204

/gfi js

Adi-204 avatar Jun 25 '25 13:06 Adi-204

anyone can take up the issue.

Adi-204 avatar Jun 25 '25 13:06 Adi-204

ohk 👍🏼

achaljhawar avatar Jun 25 '25 13:06 achaljhawar

@achaljhawar are you working on the issue? Please mention it explicitly.

Adi-204 avatar Jun 25 '25 14:06 Adi-204

Yes, I did not specifically mention it because I am still figuring out how to work on it.

@achaljhawar are you working on the issue? Please mention it explicitly.

achaljhawar avatar Jun 25 '25 14:06 achaljhawar

@achaljhawar no it is just simple refactoring what I mean is in ClientClass directly pass asyncapi obj and call helpers in ClientClass for now. Start with simpler PR will look into it. just code refactoring no need to add new code.

Adi-204 avatar Jun 25 '25 14:06 Adi-204