generator
generator copied to clipboard
fix: add missing params validation in testFile_md component
⚠️ No Changeset found
Latest commit: 1909a77b766b88a6cfa9d30acf2faa876034c145
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
Hey @toffee-k21 you have changed in wrong file. You have to do in 'apps/generator/test/test-templates/react-template/template/test-file.md.js' this file but you have done in autogenerated file 'apps/generator/test/test-templates/react-template/__transpiled/test-file.md.js' In the __transpiled folder there are autogenerated files.
Hey @ItshMoh, I've moved the file implementation to the correct folder. Let me know if this looks good or if any adjustments are needed.
Quality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
sorry but it doesn't make sense to make this change to a template that is just there for development
looks like we forgot to update sonar when we created monorepo
I will close this PR and if you really wanna help, please open a new PR and update https://github.com/asyncapi/generator/blob/master/.sonarcloud.properties with proper link to test dir in apps/generator, you can add test dir for nunjucks templates as well
sorry but it doesn't make sense to make this change to a template that is just there for development
looks like we forgot to update sonar when we created monorepo
I will close this PR and if you really wanna help, please open a new PR and update https://github.com/asyncapi/generator/blob/master/.sonarcloud.properties with proper link to test dir in apps/generator, you can add test dir for nunjucks templates as well
Hey @derberg, I've updated the paths to the test directories as requested in PR https://github.com/asyncapi/generator/pull/1311. Is this the update you were looking for?