generator icon indicating copy to clipboard operation
generator copied to clipboard

fix: add missing params validation in testFile_md component

Open toffee-k21 opened this issue 1 year ago • 4 comments

Description

  • add props validation mentioned here : these_issue
  • also mentioned in this issue : #1272

toffee-k21 avatar Oct 22 '24 09:10 toffee-k21

⚠️ No Changeset found

Latest commit: 1909a77b766b88a6cfa9d30acf2faa876034c145

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Oct 22 '24 09:10 changeset-bot[bot]

Hey @toffee-k21 you have changed in wrong file. You have to do in 'apps/generator/test/test-templates/react-template/template/test-file.md.js' this file but you have done in autogenerated file 'apps/generator/test/test-templates/react-template/__transpiled/test-file.md.js' In the __transpiled folder there are autogenerated files.

ItshMoh avatar Oct 22 '24 14:10 ItshMoh

Hey @ItshMoh, I've moved the file implementation to the correct folder. Let me know if this looks good or if any adjustments are needed.

toffee-k21 avatar Oct 22 '24 16:10 toffee-k21

sorry but it doesn't make sense to make this change to a template that is just there for development

looks like we forgot to update sonar when we created monorepo

I will close this PR and if you really wanna help, please open a new PR and update https://github.com/asyncapi/generator/blob/master/.sonarcloud.properties with proper link to test dir in apps/generator, you can add test dir for nunjucks templates as well

derberg avatar Oct 28 '24 14:10 derberg

sorry but it doesn't make sense to make this change to a template that is just there for development

looks like we forgot to update sonar when we created monorepo

I will close this PR and if you really wanna help, please open a new PR and update https://github.com/asyncapi/generator/blob/master/.sonarcloud.properties with proper link to test dir in apps/generator, you can add test dir for nunjucks templates as well

Hey @derberg, I've updated the paths to the test directories as requested in PR https://github.com/asyncapi/generator/pull/1311. Is this the update you were looking for?

toffee-k21 avatar Oct 29 '24 04:10 toffee-k21