generator
generator copied to clipboard
refactor: improved readability by removing the unnecesary escape character in generator.js
⚠️ No Changeset found
Latest commit: 5573e4ec7dc86796b9091e0e06c52f9cf0f167f3
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
This one ain't gonna be that easy, you will have to do some more tests locally. Luckily, because we will deprecate nunjucks soon, you just need to do manual tests.
manual testing is described in https://github.com/asyncapi/generator/blob/master/Development.md
your change affects this feature: https://www.asyncapi.com/docs/tools/generator/file-templates
so you need to manually (just on local, without pushing to PR) test nunjucks project by extending it with some file template, and running generation, and sharing logs in this PR that show all works well. You need to add this feature in https://github.com/asyncapi/generator/tree/master/apps/generator/test/test-templates/nunjucks-template/template
some example you can copy -> https://github.com/asyncapi/template-for-generator-templates/tree/nunjucks/template/schemas
good luck!
sorry i was out of town on vacation so couldn't work on this i will start working on this from today
Quality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
@rishabhr4 I'll be closing this one as there is no point for having a PR handing like this with no action. Feel free to open a followup once ready, especially with manual tests done