generator icon indicating copy to clipboard operation
generator copied to clipboard

Hacktoberfest easy issues

Open derberg opened this issue 1 year ago • 15 comments

I'm not going to create separate issues as this would be too much work that is not really needed.

So let us experiment and see if one issue is enough.

SonarCloud suggestions

50 small fixes can be done to improve the quality of this project. All are listed here: https://sonarcloud.io/project/issues?issueStatuses=OPEN%2CCONFIRMED&id=asyncapi_generator

Process of work:

  1. Go to https://sonarcloud.io/project/issues?issueStatuses=OPEN%2CCONFIRMED&id=asyncapi_generator
  2. Pick an issue and in comment of this GH issue write that you will work on this given SonarCloud issue, link it like so: https://sonarcloud.io/project/issues?issueStatuses=OPEN%2CCONFIRMED&id=asyncapi_generator&open=AZB4sejpgviDxNeZYbKX and write how you will fix it
  3. Once I give a green light, please go ahead and open a PR
  4. In PR do not say that given PR fixes this GitHub Issue but is just related to it

Tests

Use our new dev guide https://github.com/asyncapi/generator/blob/master/Development.md and install the project and run tests. At the run summary you will see the test coverage overview. You can just open a PR that adds one of the missing tests. In description just make sure you show test coverage report before and then after adding the test, so it makes review easier, and shows improvements are really there.

Should be good 😄 Happy Hacktoberfesting!

derberg avatar Oct 02 '24 15:10 derberg

Hey I wanted to work on this will you please assigned to me https://sonarcloud.io/project/issues?cleanCodeAttributeCategories=INTENTIONAL&issueStatuses=OPEN%2CCONFIRMED&id=asyncapi_generator&open=AZB4sekEgviDxNeZYbKm

thebedigupta avatar Oct 02 '24 15:10 thebedigupta

Hey I wanted to work on this will you please assigned to me https://sonarcloud.io/project/issues?cleanCodeAttributeCategories=INTENTIONAL&issueStatuses=OPEN%2CCONFIRMED&id=asyncapi_generator&open=AZB4sekEgviDxNeZYbKm

@thebedigupta we don't assign issues, please go ahead and work on it :)

AceTheCreator avatar Oct 02 '24 16:10 AceTheCreator

Should I have to solve all issues in One PR?

thebedigupta avatar Oct 02 '24 16:10 thebedigupta

I also want to work on these issues

ManikantaMandala avatar Oct 02 '24 17:10 ManikantaMandala

Should I have to solve all issues in One PR?

No need to solve all issues in one PR instead open separate PRs resolving issues which will help maintainers to efficient review PR

DhairyaMajmudar avatar Oct 02 '24 18:10 DhairyaMajmudar

Hey I wanted to work on this issue https://sonarcloud.io/project/issues?languages=js&issueStatuses=OPEN%2CCONFIRMED&id=asyncapi_generator&open=AZB4sejpgviDxNeZYbKZ

rishabhr4 avatar Oct 03 '24 05:10 rishabhr4

Hey I wanted to work on this issue https://sonarcloud.io/project/issues?languages=js&issueStatuses=OPEN%2CCONFIRMED&id=asyncapi_generator&open=AZB4sejpgviDxNeZYbKZ

Raise a PR if you think so

Gmin2 avatar Oct 03 '24 06:10 Gmin2

Hey I wanted to work on this issue https://sonarcloud.io/project/issues?languages=js&issueStatuses=OPEN%2CCONFIRMED&id=asyncapi_generator&open=AZB4sejpgviDxNeZYbKZ

Raise a PR if you think so

Raised a PR , please let me know if any changes are required

rishabhr4 avatar Oct 03 '24 06:10 rishabhr4

raised a pr for this issue

ManikantaMandala avatar Oct 03 '24 07:10 ManikantaMandala

Hey, I want to work on this issue : - https://sonarcloud.io/project/issues?open=AZD-TPs2DKL_zKkK1XuA&id=asyncapi_generator . Can I work?

yashsaraswat2004 avatar Oct 04 '24 06:10 yashsaraswat2004

Hey folks, we do not assign issues, if you see any issue/s you're interested in and there's currently no PR for it, kindly go ahead and work on it 🚀

AceTheCreator avatar Oct 04 '24 10:10 AceTheCreator

hey folks, be patient here 🙏🏼 there are many PRs that we need to review, also test runs are not fast. If you wanna speed up, make sure you run tests locally and check if the pass. I already noticed in one PR that contributor did not do it, and then merging have to take more time as they need to followup, etc

derberg avatar Oct 07 '24 15:10 derberg

also, folks please do not address any fixes or anything in cli.js file

derberg avatar Oct 08 '24 16:10 derberg

Hey I wanted to work on this issue https://sonarcloud.io/project/issues?issueStatuses=OPEN%2CCONFIRMED&id=asyncapi_generator&open=AZB4sejpgviDxNeZYbKd&tab=code

D-I-R-M avatar Oct 18 '24 06:10 D-I-R-M

Hey I wanted to work on this issue https://sonarcloud.io/project/issues?issueStatuses=OPEN%2CCONFIRMED&id=asyncapi_generator&open=AZB4sejpgviDxNeZYbKd&tab=code

Before working on this have a look at pinned issue

No need to ask for assign this issue if you think you can then go for it

thebedigupta avatar Oct 18 '24 15:10 thebedigupta

fest is over, closing

derberg avatar Jan 08 '25 15:01 derberg