generator icon indicating copy to clipboard operation
generator copied to clipboard

fix: add the migration guide and nunjucks depreciation notes

Open Gmin2 opened this issue 1 year ago • 9 comments

Description Add a migration guide markdown to migrate from nunjucks to react render engine

Related to #1255

Gmin2 avatar Aug 11 '24 20:08 Gmin2

🦋 Changeset detected

Latest commit: 8074398964560f06282af4b71f65102d30258029

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@asyncapi/generator Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Aug 11 '24 20:08 changeset-bot[bot]

Does i also remove the code that is present for nunjucks render engine too in this PR

cc @derberg @lmgyuan

Gmin2 avatar Aug 11 '24 20:08 Gmin2

no, we deprecate it now, inform people that removal will take place in a year. So critical is to inform when and what functionality is removed, and how to migrate to alternative - react

derberg avatar Aug 12 '24 11:08 derberg

any updates @Gmin2 ?

derberg avatar Sep 16 '24 12:09 derberg

  • have a look on PR from @lmgyuan about cli deprecation. We need similar detailed information here, about deprecation of nunjucks september 2025

@derberg dont you think this needed to be in the issue itself, not in the PR, as this is a migration guide

thoughts @lmgyuan @Florence-Njeri ?

Gmin2 avatar Sep 18 '24 07:09 Gmin2

@Gmin2 that was 3 weeks ago so I don't 100% remember what I was referring to, but afaik, it was about the README.md

derberg avatar Sep 18 '24 08:09 derberg

Hey updated the changes, take a look

cc @derberg @Florence-Njeri

Gmin2 avatar Oct 10 '24 09:10 Gmin2

closing continuation https://github.com/asyncapi/generator/pull/1331

derberg avatar Jan 20 '25 15:01 derberg