avt_vimba_camera
avt_vimba_camera copied to clipboard
Trigger Node not using ActionDeviceKey ActionGroupKey ActionGroupMask values
The trigger node example is not using the launch file parsed data https://github.com/astuff/avt_vimba_camera/blob/ros1_master/src/trigger.cpp#L73
bool Trigger::PrepareActionCommand()
{
return (SetIntFeatureValue("ActionDeviceKey", 1) && SetIntFeatureValue("ActionGroupKey", 1) &&
SetIntFeatureValue("ActionGroupMask", 1));
}
Should use the object property instead of one int action_device_key_; int action_group_key_; int action_group_mask_;
bool Trigger::PrepareActionCommand()
{
return (SetIntFeatureValue("ActionDeviceKey", action_device_key_) && SetIntFeatureValue("ActionGroupKey", action_group_key_) &&
SetIntFeatureValue("ActionGroupMask", action_group_mask_));
}
Good catch! feel free to open a PR to fix it.