avt_vimba_camera icon indicating copy to clipboard operation
avt_vimba_camera copied to clipboard

Trigger Node not using ActionDeviceKey ActionGroupKey ActionGroupMask values

Open dagata-mining opened this issue 3 years ago • 1 comments

The trigger node example is not using the launch file parsed data https://github.com/astuff/avt_vimba_camera/blob/ros1_master/src/trigger.cpp#L73


bool Trigger::PrepareActionCommand()
{
  return (SetIntFeatureValue("ActionDeviceKey", 1) && SetIntFeatureValue("ActionGroupKey", 1) &&
          SetIntFeatureValue("ActionGroupMask", 1));
}

Should use the object property instead of one int action_device_key_; int action_group_key_; int action_group_mask_;


bool Trigger::PrepareActionCommand()
{
  return (SetIntFeatureValue("ActionDeviceKey", action_device_key_) && SetIntFeatureValue("ActionGroupKey", action_group_key_) &&
          SetIntFeatureValue("ActionGroupMask", action_group_mask_));
}

dagata-mining avatar Sep 14 '22 02:09 dagata-mining

Good catch! feel free to open a PR to fix it.

icolwell-as avatar Oct 06 '22 19:10 icolwell-as