ccdproc icon indicating copy to clipboard operation
ccdproc copied to clipboard

DOC: adapt a docstest for numpy 2 (representation of scalars changed)

Open neutrinoceros opened this issue 1 year ago • 1 comments

This is similar to https://github.com/astropy/astropy/pull/15065 Since there is no simple way to have these doctests pass with both versions of numpy, my understanding is that this should be merged after numpy 2.0.0 final comes out.

xref: https://numpy.org/devdocs/release/2.0.0-notes.html#representation-of-numpy-scalars-changed

neutrinoceros avatar Apr 10 '24 07:04 neutrinoceros

It's not user impacting, but it might still be helpful to convert to a Python float so the test pass with any NumPy. Let me know if it seems acceptable to you @mwcraig

neutrinoceros avatar Apr 10 '24 13:04 neutrinoceros

It's not user impacting, but it might still be helpful to convert to a Python float so the test pass with any NumPy. Let me know if it seems acceptable to you @mwcraig

This seems fine -- hopefully the next release of ccdproc (including the tests) can be compatible with both numpy 1.x mn numpy 2.x

mwcraig avatar Apr 11 '24 14:04 mwcraig

@neutrinoceros -- can you please add yourself to the list of contributors? The changes you have been making have been super helpful!

mwcraig avatar Apr 11 '24 14:04 mwcraig

Sure thing. Let me open a separate PR for that !

neutrinoceros avatar Apr 11 '24 14:04 neutrinoceros

@mwcraig I just rebased this with the more portable change

neutrinoceros avatar Apr 11 '24 14:04 neutrinoceros

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.62%. Comparing base (c72a2e9) to head (349ed6e). Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #826      +/-   ##
==========================================
+ Coverage   97.55%   97.62%   +0.06%     
==========================================
  Files           9        9              
  Lines        1392     1388       -4     
==========================================
- Hits         1358     1355       -3     
+ Misses         34       33       -1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Apr 11 '24 14:04 codecov[bot]