ccdproc
ccdproc copied to clipboard
DOC: adapt a docstest for numpy 2 (representation of scalars changed)
This is similar to https://github.com/astropy/astropy/pull/15065 Since there is no simple way to have these doctests pass with both versions of numpy, my understanding is that this should be merged after numpy 2.0.0 final comes out.
xref: https://numpy.org/devdocs/release/2.0.0-notes.html#representation-of-numpy-scalars-changed
It's not user impacting, but it might still be helpful to convert to a Python float so the test pass with any NumPy. Let me know if it seems acceptable to you @mwcraig
It's not user impacting, but it might still be helpful to convert to a Python float so the test pass with any NumPy. Let me know if it seems acceptable to you @mwcraig
This seems fine -- hopefully the next release of ccdproc (including the tests) can be compatible with both numpy 1.x mn numpy 2.x
@neutrinoceros -- can you please add yourself to the list of contributors? The changes you have been making have been super helpful!
Sure thing. Let me open a separate PR for that !
@mwcraig I just rebased this with the more portable change
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 97.62%. Comparing base (
c72a2e9) to head (349ed6e). Report is 9 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #826 +/- ##
==========================================
+ Coverage 97.55% 97.62% +0.06%
==========================================
Files 9 9
Lines 1392 1388 -4
==========================================
- Hits 1358 1355 -3
+ Misses 34 33 -1
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.