ccdproc icon indicating copy to clipboard operation
ccdproc copied to clipboard

A bug in ImageFileCollection.filter

Open RuiningZHAO opened this issue 1 year ago • 1 comments

There is a bug in ImageFileCollection.filter.

class ImageFileCollection:
    ...
    def filter(self, **kwd):
        ...
        files = self.files_filtered(include_path=True, **kwd)
        return ImageFileCollection(filenames=files,
                                   keywords=self.keywords)

The call of ImageFileCollection here should be with arg ext, otherwise the keywords not in the first extension will become -- in the returned collection.

RuiningZHAO avatar Dec 13 '23 04:12 RuiningZHAO

Thanks for reporting this, @RuiningZHAO -- I'll try to get to this in the next couple of weeks, but I'd be happy to review a PR to fix it sooner than that :)

mwcraig avatar Dec 18 '23 17:12 mwcraig