astro-cli icon indicating copy to clipboard operation
astro-cli copied to clipboard

Simple Generic PoC for 1.18 - List Contains util

Open alex-astronomer opened this issue 3 years ago โ€ข 1 comments

Description

PoC for 1.18. Changes the string contains method that finds a string in a list of strings to be generic for any type that is comparable.

๐ŸŽŸ Issue(s)

n/a

๐Ÿงช Functional Testing

Existing unit tests are adequate

๐Ÿ“‹ Checklist

  • [ x] Rebased from the main (or release if patching) branch (before testing)
  • [x] Ran make test before taking out of draft
  • [x] Ran make lint before taking out of draft
  • [x] Added/updated applicable tests
  • [x] Tested against Astro-API (if necessary).
  • [x] Tested against Houston-API and Astronomer (if necessary).
  • [x] Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • [x] Updated any related documentation

alex-astronomer avatar Jun 01 '22 21:06 alex-astronomer

@alex-astronomer please fix lint and tests.

andriisoldatenko avatar Jun 02 '22 09:06 andriisoldatenko

@alex-astronomer closing this PR due to inactivity, feel free to reopen if you continue to work on it

neel-astro avatar Jan 10 '23 08:01 neel-astro