ruff
ruff copied to clipboard
astral-sh
[red-knot] invalidation on file change doesn't work in CLI with relative paths
Given these files:
# main.py
from typing import override
from base import B
foo = override
class C(B):
@foo
def method(self): pass
# base.py
class B: pass
# typing.py
def override(func):
return func
Running cargo run --bin red_knot path/to/that/dir/main.py correctly gives a bad-override diagnostic.
If we remove the @foo line in main.py and re-run the CLI from start, it correctly does not give a diagnostic.
But in either case if we add or remove the @foo line while the CLI is still running, it appears to re-execute some queries, but it fails to correctly account for the change (the diagnostic remains present or absent as it was on the first run, disregarding the change.)
From the traces after the file change, it looks like it's just not recognizing the file has been modified at all; there are some file_system queries but no semantic index of main.py or anything else.
It looks like this is a path normalization issue. Invalidation works correctly if I run cargo run --bin red_knot /absolute/path/to/the/dir/main.py, but fails if I run cargo run --bin red_knot ../path/to/the/dir/main.py.
