ruff icon indicating copy to clipboard operation
ruff copied to clipboard

Update annotate-snippets to 0.11.0

Open MichaReiser opened this issue 1 year ago • 2 comments

See https://github.com/astral-sh/ruff/pull/10699

CC: @carljm in case you plan to work on this.

We may also decide not to use annotate-snippets anymore (it has some weirdness like it supports some markup that can mess up rendering)

MichaReiser avatar Apr 08 '24 07:04 MichaReiser

This will be useful for the new parser test cases as well. If I understand this correctly, https://github.com/rust-lang/annotate-snippets-rs/pull/107 allows highlighting empty spans which can occur at EOF. You might've noticed that there are no error messages in some of the cases :)

dhruvmanila avatar Apr 08 '24 12:04 dhruvmanila

Oh nice, that annoyed me for a long time. I think we should also change the expected errors to point to an empty range that starts at the next token's position instead of using the entire range of the next token.

MichaReiser avatar Apr 08 '24 12:04 MichaReiser