ruff icon indicating copy to clipboard operation
ruff copied to clipboard

Set PowerPC Page Size to 64KB

Open MichaReiser opened this issue 1 year ago • 1 comments

Summary

Fixes https://github.com/astral-sh/ruff/issues/10073

We had a similar issue with aarch64 and the fix was to increase the page size to 64KB: https://github.com/astral-sh/ruff/issues/3791#issuecomment-1488100121

The issue seems to be that jemalloc is compiled with fixed page sizes and using a larger page size than what it is compiled for segfaults. But jemalloc supports running on systems with smaller page sizes then configured at compile time. Sources: [1, 2]

This PR does the same for PowerPC because widely used PowerPC systems use a default page size of 64KB source

Test Plan

MichaReiser avatar Feb 22 '24 13:02 MichaReiser

@nwf could you try one of the power pc binaries from (either wheel or from binaries) and report back if they are now working for you?

https://github.com/astral-sh/ruff/actions/runs/8005385997#artifacts

I can't test it myself because I don't have a power pc cpu

MichaReiser avatar Feb 22 '24 18:02 MichaReiser

Much better, thanks!

0abaa1dc35a7% ./ruff 
Ruff: An extremely fast Python linter.

nwf avatar Feb 23 '24 05:02 nwf

Awesome. Thank you @nwf for testing the change

MichaReiser avatar Feb 23 '24 07:02 MichaReiser