ast-grep-vscode icon indicating copy to clipboard operation
ast-grep-vscode copied to clipboard

Published 20 hours ago • verified publisher icon ast-grep

chore(infra): move tests folder to top level

Open SoonIter opened this issue 1 year ago • 2 comments

Ellipsis :rocket: This PR description was created by Ellipsis for commit 1f11b4f818a070bbf23e8efad8a9f6854cede2dd.

Summary:

This PR moves the tests folder to the top level of the project structure and updates various files to reflect this change, including workflow files, test setup scripts, and test files.

Key points:

  • Moved tests folder to top level.
  • Updated .github/workflows/ci.yml and .github/workflows/publish.yml to use .nvmrc for Node.js version.
  • Updated scripts/test/testSetup.ts to import activate from new utils location.
  • Updated src/extension.ts to use path.join for configUri.
  • Moved and updated test files in src/test to tests.
  • Moved and updated src/test/utils.ts to tests/utils.ts.

Generated with :heart: by ellipsis.dev

SoonIter avatar Feb 07 '24 09:02 SoonIter

any merit to move test to top level?

HerringtonDarkholme avatar Feb 07 '24 18:02 HerringtonDarkholme

any merit to move test to top level?

:-) There are no obvious benefits but I think we will move the tests directory to the top layer sooner or later, because we use tsx to run ts code instead of compiling it. By the way, I'm testing the failing reason for window CI in this pr , it seems that Macos is also unstable ...

SoonIter avatar Feb 08 '24 07:02 SoonIter