libuv-build icon indicating copy to clipboard operation
libuv-build copied to clipboard

Build and pack symbols for libuv

Open muratg opened this issue 7 years ago • 9 comments
trafficstars

From @JunTaoLuo on February 23, 2018 2:4

The libuv packages we build do not have any corresponding debug symbols. We should explore how we can produce and pack debug symbols in a libuv symbols package and publish this to the symbols server.

cc @davidfowl @halter73 for libuv expertise cc @Eilon @muratg for triage cc @natemcmaster for including additional symbols packages in our build.

Copied from original issue: aspnet/Home#2898

muratg avatar Mar 19 '18 17:03 muratg

From @halter73 on February 23, 2018 2:45

Are we going to include the symbols in the main nuget package or on a myget symbol server?

The last time we discussed this, I was told we were saving the old symbols so we could upload them to a symbol server retroactively.

muratg avatar Mar 19 '18 17:03 muratg

From @JunTaoLuo on February 23, 2018 3:5

Apparently we produce these in the libuv-build-windows builds, e.g. $DROPSHARE\libuv-build-windows\dev\10077\build\symbols. We should package these into symbols nupkgs and publish these along with our other symbols.

muratg avatar Mar 19 '18 17:03 muratg

From @davidfowl on March 16, 2018 9:54

@JunTaoLuo did we ever look at this?

muratg avatar Mar 19 '18 17:03 muratg

From @JunTaoLuo on March 16, 2018 17:6

Nope we never triaged this. cc @muratg

muratg avatar Mar 19 '18 17:03 muratg

From @Eilon on March 19, 2018 16:53

Should this bug go to one of our libuv repos?

muratg avatar Mar 19 '18 17:03 muratg

From @JunTaoLuo on March 19, 2018 17:3

Yes, and we should do this the next time we build libuv

muratg avatar Mar 19 '18 17:03 muratg

@muratg - candidate to move to RC?

Eilon avatar Mar 27 '18 16:03 Eilon

@Eilon yes.

muratg avatar Mar 27 '18 16:03 muratg

Moving this further out. We're making Sockets the default so this is a little less important.

muratg avatar Mar 28 '18 21:03 muratg