RoslynCodeDomProvider icon indicating copy to clipboard operation
RoslynCodeDomProvider copied to clipboard

Published 20 hours ago • verified publisher icon aspnet

Fixed MSBuild 17.7 issue.

Open AraHaan opened this issue 2 years ago • 9 comments

This should fix an issue with newer versions of msbuid for both .NET SDK style and non-SDK style projects all in one.

Fixes #154.

AraHaan avatar Aug 16 '23 03:08 AraHaan

cc: @StephenMolloy

AraHaan avatar Aug 22 '23 01:08 AraHaan

Any chance getting this merged and a new version released?

danpetitt avatar Aug 29 '23 08:08 danpetitt

The warnings this is causing are breaking our CI builds, can we merge this and release a new version please?

robmaas avatar Aug 31 '23 11:08 robmaas

Looking forward this to being merged.

fiseni avatar Sep 08 '23 09:09 fiseni

If you guys are also interested I also opened a pull request for shipping this package with roslyn 4.7 which is more updated and modern version of roslyn with updated c# language versions support as well.

AraHaan avatar Sep 09 '23 08:09 AraHaan

The warnings this is causing are breaking our CI builds, can we merge this and release a new version please?

Can you please elaborate on this? The new MSBuild message isn't a warning, it's a message. How is it breaking your CI?

rainersigwald avatar Oct 05 '23 15:10 rainersigwald

The warnings this is causing are breaking our CI builds, can we merge this and release a new version please?

Can you please elaborate on this? The new MSBuild message isn't a warning, it's a message. How is it breaking your CI?

It is breaking it because it helps point out that msbuild was unable to copy the files at all for the reason that the message pointed out.

The lack of the compiler files themselves is what is breaking which ironically fixes itself when the changes in this patch is applied.

AraHaan avatar Oct 06 '23 15:10 AraHaan

Can you please elaborate on this? The new MSBuild message isn't a warning, it's a message. How is it breaking your CI?

When this issue started it also showed as building warnings in our build in Hosted Azure DevOps agents. Since we have a no-tolerance process it broke our deployment process. At the moment those warnings no longer show up in the pipelines, not sure what changed but they definitely did before.

robmaas avatar Oct 06 '23 17:10 robmaas

Can you please elaborate on this? The new MSBuild message isn't a warning, it's a message. How is it breaking your CI?

When this issue started it also showed as building warnings in our build in Hosted Azure DevOps agents. Since we have a no-tolerance process it broke our deployment process. At the moment those warnings no longer show up in the pipelines, not sure what changed but they definitely did before.

Also since then has the roslyn binaries vanished from deployments as well in the agents?

AraHaan avatar Oct 06 '23 18:10 AraHaan