BrowserLink icon indicating copy to clipboard operation
BrowserLink copied to clipboard

TaskHelpers_WaitWithTimeout_ReturnsTimeoutResultIfTaskNotComplete fails on xplat

Open pranavkm opened this issue 8 years ago • 4 comments
trafficstars

[xUnit.net 00:00:03.9067481]     Microsoft.VisualStudio.Web.BrowserLink.TaskHelpersTest.TaskHelpers_WaitWithTimeout_ReturnsTimeoutResultIfTaskNotComplete [FAIL]
[xUnit.net 00:00:03.9089484]       Task did not time out
Test Run Failed.

[xUnit.net 00:00:03.9092846]       Expected: True
[xUnit.net 00:00:03.9094667]       Actual:   False
[xUnit.net 00:00:03.9105680]       Stack Trace:

@YangLyu89, I'll skip it on xplat for now. Feel free to investigate it.

pranavkm avatar Mar 08 '17 20:03 pranavkm

This test is also flaky on Windows machines. I have seen failures on Win2008 and Win2012

JunTaoLuo avatar Mar 13 '17 21:03 JunTaoLuo

Skipping in https://github.com/aspnet/BrowserLink/commit/e270041fa1c8a83a973f8a513b03daacb9925618 Please investigate the test failure and re-enable.

JunTaoLuo avatar Mar 13 '17 22:03 JunTaoLuo

@jodavis - does anyone need to take a look at this issue? Are we missing important coverage because this test is disabled?

Eilon avatar Apr 10 '18 21:04 Eilon

No, we're not missing important coverage. It's probably not a product issue, just that the timeout needs to be increased to account for weird task timing in the test runner. I'll have someone fix it soon.

jodavis avatar Apr 11 '18 22:04 jodavis