rules_ts icon indicating copy to clipboard operation
rules_ts copied to clipboard

feat: support --noCheck for transpiling without type-checking

Open jbedard opened this issue 1 year ago • 2 comments

Implement the ts_project(isolated_declarations) parameter and support for type-checking dependent projects in parallel.

When isolated_declarations is set it is assumed tsc can emit the declaration files without the need for declarations from dependencies. This way the only inputs required to tsc are the source files and config, not dependencies.

Full type-checking is done as a separate isolated validation action which does depend on all transitive declarations.

Close #374 Ref #374, #679

See future improvements to noCheck

Before (backend+frontend don't start until core finishes): Screenshot 2024-08-30 at 6 22 40 PM

After (core+backend+frontend compile with --noCheck up front, but backend+frontend don't typecheck until core finishes): Screenshot 2024-08-30 at 6 45 12 PM Screenshot 2024-08-30 at 6 27 16 PM


Changes are visible to end-users: no

Test plan

  • Covered by existing test cases
  • New test cases added

jbedard avatar Aug 29 '24 21:08 jbedard

Test

All tests were cache hits

92 tests (100.0%) were fully cached saving 8s.


Buildifier      Format

aspect-workflows[bot] avatar Aug 29 '24 21:08 aspect-workflows[bot]

Depends on https://github.com/aspect-build/rules_ts/pull/678

jbedard avatar Aug 29 '24 21:08 jbedard