rules_ts icon indicating copy to clipboard operation
rules_ts copied to clipboard

feat: expose protoc_gen_options on ts_proto_library

Open mattem opened this issue 1 year ago • 1 comments

Exposes a dict for setting options on protoc_gen on the ts_proto_library


Changes are visible to end-users: yes

  • Searched for relevant documentation and updated as needed: yes
  • Breaking change (forces users to change their own code or config): no
  • Suggested release notes appear below:

Allow custom options to be set on ts_proto_library for protoc-gen.

Test plan

  • Manual testing; please provide instructions so we can reproduce:

Run locally patched in Silo.

mattem avatar Jul 12 '24 19:07 mattem

Test

All tests were cache hits

81 tests (100.0%) were fully cached saving 12s.


Buildifier      Format

aspect-workflows[bot] avatar Jul 12 '24 19:07 aspect-workflows[bot]

Can we make this an explicit argument in the public macro and document it there?

jbedard avatar Jul 23 '24 20:07 jbedard