always set 'use_default_shell_env' in ctx.actions.run

Open malt3 opened this issue 1 year ago • 1 comments

Aspect uses shell wrappers that invoke tools like dirname and uname. When the default shell env is not inherited, this prevents tools from being found on systems without a working fallback $PATH (like NixOS).

This might be incompatible with setting the env attribute, unless the bazel flag --incompatible_merge_fixed_and_default_shell_env is set on Bazel versions < 7.

See also: https://github.com/NixOS/nixpkgs/issues/289505

Changes are visible to end-users: no

Test plan

Covered by existing test cases

Jun 04 '24 12:06 malt3

thanks for this fix! any chance to merge that?

Nov 12 '24 00:11 dimatosaurus

FYI this PR unblocks me using rules_ts on my NixOS development machine. Would be great to remove the single_version_override in our work repo :)

Mar 24 '25 15:03 keegancsmith

Friendly ping to @alexeagle

Mar 24 '25 16:03 malt3

CI seems to be stuck?

Mar 25 '25 05:03 keegancsmith

Test

1 test target passed

Targets

//.github/workflows:update_aspect_bazelrc_presets_test [k8-fastbuild] 35ms

Total test execution time was 35ms. 170 tests (99.4%) were fully cached saving 12s.

Buildifier Format

Mar 26 '25 13:03 aspect-workflows[bot]