rules_ts
rules_ts copied to clipboard
Aspect rbe
Need to verify that we still have e2e coverage. Also note that we lose coverage for macos and windows as RBE clients.
Type of change
- Refactor (a code change that neither fixes a bug or adds a new feature)
Test plan
- Covered by existing test cases
@CaerusKaru we do want to land this now, correct?
Test
:warning: GitHub Actions build #522 failed.
//examples/custom_compiler:big failed to build
error TS5033: Could not write file '/mnt/ephemeral/output/__main__/execroot/_main/bazel-out/k8-fastbuild/bin/examples/custom_compiler/component.js': EACCES: permission denied, open '/mnt/ephemeral/output/__main__/execroot/_main/bazel-out/k8-fastbuild/bin/examples/custom_compiler/component.js'.
//examples/deps_lib_transpiler/b:b_typings failed to build
error TS6059: File '/mnt/ephemeral/output/__main__/execroot/_main/bazel-out/k8-fastbuild/bin/examples/deps_lib_transpiler/importer_linked.ts' is not under 'rootDir' '/mnt/ephemeral/output/__main__/execroot/_main/bazel-out/k8-fastbuild/bin/examples/deps_lib_transpiler/b'. 'rootDir' is expected to contain all source files.
The file is in the program because:
Matched by default include pattern '**/*'
error TS6059: File '/mnt/ephemeral/output/__main__/execroot/_main/bazel-out/k8-fastbuild/bin/examples/deps_lib_transpiler/importer_rel.ts' is not under 'rootDir' '/mnt/ephemeral/output/__main__/execroot/_main/bazel-out/k8-fastbuild/bin/examples/deps_lib_transpiler/b'. 'rootDir' is expected to contain all source files.
The file is in the program because:
Matched by default include pattern '**/*'
//examples/ts_project_dep/b:ts failed to build
error TS5033: Could not write file '/mnt/ephemeral/output/__main__/execroot/_main/bazel-out/k8-fastbuild/bin/examples/ts_project_dep/a/a.js': EACCES: permission denied, open '/mnt/ephemeral/output/__main__/execroot/_main/bazel-out/k8-fastbuild/bin/examples/ts_project_dep/a/a.js'. examples/ts_project_dep/b/b.ts(1,19): error TS6059: File '/mnt/ephemeral/output/__main__/execroot/_main/bazel-out/k8-fastbuild/bin/examples/ts_project_dep/a/a.ts' is not under 'rootDir' '/mnt/ephemeral/output/__main__/execroot/_main/bazel-out/k8-fastbuild/bin/examples/ts_project_dep/b'. 'rootDir' is expected to contain all source files.
//examples/deps_lib/b:b failed to build
error TS6059: File '/mnt/ephemeral/output/__main__/execroot/_main/bazel-out/k8-fastbuild/bin/examples/deps_lib/importer_linked.ts' is not under 'rootDir' '/mnt/ephemeral/output/__main__/execroot/_main/bazel-out/k8-fastbuild/bin/examples/deps_lib/b'. 'rootDir' is expected to contain all source files.
The file is in the program because:
Matched by default include pattern '**/*'
error TS6059: File '/mnt/ephemeral/output/__main__/execroot/_main/bazel-out/k8-fastbuild/bin/examples/deps_lib/importer_rel.ts' is not under 'rootDir' '/mnt/ephemeral/output/__main__/execroot/_main/bazel-out/k8-fastbuild/bin/examples/deps_lib/b'. 'rootDir' is expected to contain all source files.
The file is in the program because:
Matched by default include pattern '**/*'
//examples/dts_lib:lib failed to build
examples/dts_lib/importer_linked.ts(1,22): error TS2307: Cannot find module '@myorg/dts_lib' or its corresponding type declarations.
:bulb: To reproduce the build failures, run
bazel build //examples/custom_compiler:big //examples/deps_lib_transpiler/b:b_typings //examples/ts_project_dep/b:ts //examples/deps_lib/b:b //examples/dts_lib:lib
Buildifier
Format
Closing in favor of https://github.com/aspect-build/rules_ts/pull/612