rules_ts icon indicating copy to clipboard operation
rules_ts copied to clipboard

feat: provide a way for individual ts_project targets to reserve extr…

Open alexeagle opened this issue 1 year ago • 2 comments

…a RAM

Some targets are globs of a large amount of code. By default Bazel allocates only 250MB See https://github.com/bazelbuild/bazel/commit/d7f0724b6b91b6c57039a1634ff00ccebd872714#diff-139b184febb86269f1ceee705bde7274e2efcccaa3f435a8c6cb2f1f0854ce46R96


Type of change

  • New feature or functionality (change which adds functionality)

For changes visible to end-users

  • Relevant documentation has been updated

Test plan

  • New test cases added

alexeagle avatar Mar 15 '24 21:03 alexeagle

Note, this isn't urgent for @DavidZbarsky-at as it's already patched there, so I'll try to land the principled thing in bazel-lib first (many of our rulesets should expose this)

alexeagle avatar Mar 18 '24 16:03 alexeagle

Landed https://github.com/aspect-build/bazel-lib/pull/792

This ought to depend on bazel-lib 2.0 now, but we have the usual problem that it's a breaking change. Maybe we can have a separate entry point for ts_project_with_resource_set. Or just wait for rules_ts 3.0? Or give up on our adherence to semver and just require bazel-lib 2.0 in a 2.x release of rules_ts.

alexeagle avatar Mar 18 '24 22:03 alexeagle

Related internal thread: https://aspect-build.slack.com/archives/C05S94VJWNM/p1710536751433789?thread_ts=1710508945.458429&cid=C05S94VJWNM

gregmagolan avatar May 06 '24 17:05 gregmagolan

now that main targets rules_ts 3.x and is guaranteed to have bazel-lib 2.x, I'm unblocked to rely on the new resource_sets helper :)

alexeagle avatar Jul 10 '24 22:07 alexeagle

Test

1 test target passed

Targets
//docs:update_0_test [k8-fastbuild] 30ms

Total test execution time was 30ms. 80 tests (98.8%) were fully cached saving 12s.


Buildifier      Format

aspect-workflows[bot] avatar Jul 10 '24 22:07 aspect-workflows[bot]