rules_ts icon indicating copy to clipboard operation
rules_ts copied to clipboard
verified publisher icon aspect-build

refactor: remove unnecessary default param values

Open jbedard opened this issue 1 year ago • 1 comments

BREAKING CHANGE to the ts_lib API.

These defaults are never used internally, and are different defaults then the rules actually use which is confusing.

Type of change

  • Refactor (a code change that neither fixes a bug or adds a new feature)

Test plan

  • Covered by existing test cases

jbedard avatar Feb 08 '24 09:02 jbedard

I didn't think those were public? The reason is just that they are never used and add confusion. I think the real defaults are None yet the (unused) default param values are "."?

jbedard avatar Feb 08 '24 19:02 jbedard

Test

All tests were cache hits

65 tests (100.0%) were fully cached saving 6s.

Buildifier      Format

aspect-workflows[bot] avatar Apr 24 '24 21:04 aspect-workflows[bot]