rules_js icon indicating copy to clipboard operation
rules_js copied to clipboard

perf: do not sanitize npm package labels multiple times

Open jbedard opened this issue 1 year ago • 1 comments

Changes are visible to end-users: no

Test plan

  • Covered by existing test cases

jbedard avatar Jun 26 '24 23:06 jbedard

Test

All tests were cache hits

194 tests (100.0%) were fully cached saving 40s.


Test

e2e/bzlmod

All tests were cache hits

4 tests (100.0%) were fully cached saving 486ms.


Test

e2e/gyp_no_install_script

All tests were cache hits

2 tests (100.0%) were fully cached saving 557ms.


Test

e2e/js_image_oci

All tests were cache hits

1 test (100.0%) was fully cached saving 7s.


Test

e2e/npm_link_package

All tests were cache hits

2 tests (100.0%) were fully cached saving 654ms.


Test

e2e/npm_link_package-esm

All tests were cache hits

2 tests (100.0%) were fully cached saving 798ms.


Test

e2e/npm_translate_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.


Test

e2e/npm_translate_lock_empty

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.


Test

e2e/npm_translate_lock_multi

All tests were cache hits

2 tests (100.0%) were fully cached saving 271ms.


Test

e2e/npm_translate_lock_partial_clone

All tests were cache hits

1 test (100.0%) was fully cached saving 117ms.


Test

e2e/npm_translate_lock_subdir_patch

All tests were cache hits

1 test (100.0%) was fully cached saving 231ms.


Test

e2e/npm_translate_package_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.


Test

e2e/npm_translate_yarn_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.


Test

e2e/package_json_module

All tests were cache hits

1 test (100.0%) was fully cached saving 532ms.


Test

e2e/pnpm_lockfiles

8 test targets passed

Targets
//v54:aliases-test [k8-fastbuild]436ms
//v54:repos_0_test [k8-fastbuild]558ms
//v60:aliases-test [k8-fastbuild]416ms
//v60:repos_0_test [k8-fastbuild]635ms
//v61:aliases-test [k8-fastbuild]349ms
//v61:repos_0_test [k8-fastbuild]479ms
//v90:aliases-test [k8-fastbuild]256ms
//v90:repos_0_test [k8-fastbuild]546ms

Total test execution time was 4s. 20 tests (71.4%) were fully cached saving 6s.


Test

e2e/pnpm_workspace

3 test targets passed

Targets
//app/a:npm_link_targets_test [k8-fastbuild]398ms
//app/a:test [k8-fastbuild]2s
//app/b:test [k8-fastbuild]774ms

Total test execution time was 3s. 6 tests (66.7%) were fully cached saving 4s.


Test

e2e/pnpm_workspace_rerooted

All tests were cache hits

6 tests (100.0%) were fully cached saving 4s.


Test

e2e/repo_mapping

All tests were cache hits

2 tests (100.0%) were fully cached saving 453ms.


Test

e2e/rules_foo

All tests were cache hits

2 tests (100.0%) were fully cached saving 564ms.


Test

e2e/vendored_node

All tests were cache hits

1 test (100.0%) was fully cached saving 187ms.


Buildifier      Format

aspect-workflows[bot] avatar Jun 27 '24 00:06 aspect-workflows[bot]