feat: add with_npm_publish_target to disable npm_publish generation

[SinimaWath]

trafficstars

---

Type of change

New feature or functionality (change which adds functionality):

Arg with_npm_publish_target to npm_package to have possibility to prevent generation of {name}.publish target.

For changes visible to end-users

Suggested release notes are provided below:

Added arg with_npm_publish_target to npm_package to have possibility to prevent generation of {name}.publish target.

Test plan

Manual testing:

• Provide with_npm_publish_target = False to npm_package
• bazel query "..." | grep publish.

[CLAassistant]

All committers have signed the CLA.

[jbedard]

Seems like a reasonable idea to me.

@gregmagolan wdyt? wdyt about naming here?

[SinimaWath]

@gregmagolan Is it ok for you?

[jbedard]

@SinimaWath I think we should rename this to publishable. WDYT?

I think we should also add a TODO(2.0): switch to false and in v2 we can make the breaking change of not creating this target by default. I think most of the time packages are only used internally and this target is not even necessary. Worst case we can drop the TODO if we decide we want to keep it as true, best case we switch the default in 2.0.

[SinimaWath]

@jbedard

Looks good to me, changed that and added TODO

[thesayyn]

I proposed this back when we added the .publish target, but decided it was unnecessary. I don't think much changed since then. What would be justification for adding this other than making the query result smaller?

[SinimaWath]

@thesayyn

Yes, you're right, there are 2 reason for me: 1 - Make query result smaller 2 - Replace name.publish with our internal implementation, but keeping DX the same as using npm_package, so developers don't need to learn a new target of publishing packages. I think it's small changes, but essential.

[aspect-workflows[bot]]

Test

1 test target passed

Targets

//docs:update_6_test [k8-fastbuild] 117ms

Total test execution time was 117ms. 210 tests (99.5%) were fully cached saving 43s.

---

Test

e2e/bzlmod

All tests were cache hits

4 tests (100.0%) were fully cached saving 1s.

---

Test

e2e/gyp_no_install_script

All tests were cache hits

3 tests (100.0%) were fully cached saving 930ms.

---

Test

e2e/js_image_oci

All tests were cache hits

1 test (100.0%) was fully cached saving 5s.

---

Test

e2e/npm_link_package

All tests were cache hits

2 tests (100.0%) were fully cached saving 3s.

---

Test

e2e/npm_link_package-esm

All tests were cache hits

2 tests (100.0%) were fully cached saving 3s.

---

Test

e2e/npm_translate_lock

All tests were cache hits

2 tests (100.0%) were fully cached saving 481ms.

---

Test

e2e/npm_translate_lock_empty

All tests were cache hits

2 tests (100.0%) were fully cached saving 301ms.

---

Test

e2e/npm_translate_lock_multi

All tests were cache hits

2 tests (100.0%) were fully cached saving 435ms.

---

Test

e2e/npm_translate_lock_partial_clone

All tests were cache hits

1 test (100.0%) was fully cached saving 188ms.

---

Test

e2e/npm_translate_lock_subdir_patch

All tests were cache hits

1 test (100.0%) was fully cached saving 301ms.

---

Test

e2e/npm_translate_package_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 393ms.

---

Test

e2e/npm_translate_yarn_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 239ms.

---

Test

e2e/package_json_module

All tests were cache hits

1 test (100.0%) was fully cached saving 927ms.

---

Test

e2e/pnpm_lockfiles

All tests were cache hits

4 tests (100.0%) were fully cached saving 440ms.

---

Test

e2e/pnpm_workspace

All tests were cache hits

8 tests (100.0%) were fully cached saving 7s.

---

Test

e2e/pnpm_workspace_rerooted

All tests were cache hits

6 tests (100.0%) were fully cached saving 5s.

---

Test

e2e/repo_mapping

All tests were cache hits

2 tests (100.0%) were fully cached saving 490ms.

---

Test

e2e/rules_foo

All tests were cache hits

2 tests (100.0%) were fully cached saving 2s.

---

Test

e2e/vendored_node

All tests were cache hits

1 test (100.0%) was fully cached saving 229ms.

---

Buildifier      Format