bazel-lib icon indicating copy to clipboard operation
bazel-lib copied to clipboard

[Bug]: Yq target does not work with external builds

Open phlax opened this issue 2 years ago • 4 comments

What happened?

Cryptic message about non-existing file paths

Version

Development (host) and target OS/architectures: linux/debian

Output of bazel --version:

bazel 6.3.2

Version of the Aspect rules, or other relevant rules from your WORKSPACE or MODULE.bazel file:

1.34.1

Language(s) and/or frameworks involved:

How to reproduce

Add a yq target, try to build from an external workspace

Any other information?

I proposed a fix in #547 - seems that may not work in all situations, but at least fixes this problem

phlax avatar Sep 25 '23 05:09 phlax

I can't reproduce, I'm trying this in an external workspace in this repo:

cd e2e/smoke
bazel build @aspect_bazel_lib//lib/tests/yq:all

and it succeeds.

alexeagle avatar Oct 05 '23 15:10 alexeagle

fwiw the target i was hitting this with initally was the envoy docs - which i then debugged and added proposed fix - so pretty certain diagnosis/etc. Are you sure its seeing the target/s as external testing in this way ?

phlax avatar Oct 05 '23 15:10 phlax

Sorry, I don't mean to say there isn't a bug, I just need some help to reproduce it so I can add a test case for it and verify a fix, if it's not identical to your PR (accounting for --nolegacy_external_runfiles case)

alexeagle avatar Oct 05 '23 19:10 alexeagle

if i get some time tomorrow ill try and setup a minimal reproducer

phlax avatar Oct 05 '23 19:10 phlax