bazel-lib icon indicating copy to clipboard operation
bazel-lib copied to clipboard

yq: Fix path resolution for external targets

Open phlax opened this issue 2 years ago • 3 comments

Currently the yq target is unusable if called from an external build, this should resolve that


Type of change

  • Bug fix (change which fixes an issue)
  • New feature or functionality (change which adds functionality)
  • Style (white-space, formatting, etc...)
  • Refactor (a code change that neither fixes a bug or adds a new feature)
  • Performance (a code change that improves performance)
  • Documentation (updates to documentation or READMEs)
  • Chore (any other change that doesn't affect source or test files, such as configuration)

For changes visible to end-users

  • Breaking change (this change will force users to change their own code or config)
  • Relevant documentation has been updated
  • Suggested release notes are provided below:

Test plan

  • Covered by existing test cases
  • New test cases added
  • Manual testing; please provide instructions so we can reproduce:

phlax avatar Sep 24 '23 09:09 phlax

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Sep 24 '23 09:09 CLAassistant

It might be a good idea to file an issue for this first, in case others want to contribute a fix for it.

alexeagle avatar Sep 25 '23 00:09 alexeagle

It might be a good idea to file an issue for this first, in case others want to contribute a fix for it.

i proposed a fix as this is blocking us from being able to do some external builds - so was hoping for a quick turnaround and needed something in the interim that works

#548

phlax avatar Sep 25 '23 05:09 phlax