orama icon indicating copy to clipboard operation
orama copied to clipboard

plugin-telemetry-test seems to break when trying to commit

Open mbianchidev opened this issue 2 years ago • 2 comments

Describe the bug

I was trying to contribute with some minor improvements to orama, I followed the contributing guidelines by installing pnpm, building and then committing through pnpm commit I run into an error on the telemetry package that I'm quite sure I didn't touched at all.

Build works like a charm pnpm_build.log

Error I encounter when committing is @orama/plugin-telemetry:lint: /mnt/c/Workspace/open-source/orama/packages/plugin-telemetry/src/collector.ts:0:0: Parsing error: DeprecationError: 'originalKeywordKind' has been deprecated since v5.0.0 and can no longer be used. Use 'identifierToKeywordKind(identifier)' instead. (null)

Complete logs when pnpm commit orama-pnpm.log

Logs when git commit (trial to check if it was a pnpm problem) orama.log

Most probably I'm missing something in the inizialization process, can you help? Thanks!

To Reproduce

  1. Clone the repo
  2. Change some code
  3. Run pnpm install
  4. Run pnpm build
  5. Run pnpm commit or run git commit

Expected behavior

Being able to commit (and push)

Environment Info

OS: WSL Ubuntu 20.04 - on Windows 10
Node: v21.2.0
Orama: 2.0.0-beta.7 (monorepo)

Affected areas

Initialization

Additional context

No response

mbianchidev avatar Nov 17 '23 09:11 mbianchidev

Hi @mbianchidev , sorry for my late reply. Can you try to commit with git commit? There's a husky hook to run tests anyway, so the npm commit step is not really needed.

micheleriva avatar Dec 01 '23 17:12 micheleriva

Logs when git commit (trial to check if it was a pnpm problem) orama.log

These are the logs when running git commit (I tried it to check if it was a pnpm problem) - already attached in the issue orama.log

Extracted the error without context

@orama/plugin-telemetry:test: ERROR: command finished with error: command (/mnt/c/Workspace/open-source/orama/packages/plugin-telemetry) pnpm run test exited (1)
@orama/orama:test: node:internal/errors:513
@orama/orama:test:       throw error;
@orama/orama:test:       ^
@orama/orama:test:
@orama/orama:test: TypeError [ERR_INVALID_ARG_TYPE]: The "code" argument must be of type number. Received type string ('128SIGINT')
@orama/orama:test:     at process.set [as exitCode] (node:internal/bootstrap/node:123:9)
@orama/orama:test:     at ChildProcess.<anonymous> (/mnt/c/Workspace/open-source/orama/node_modules/.pnpm/[email protected]/node_modules/foreground-child/index.js:63:22)
@orama/orama:test:     at ChildProcess.emit (node:events:519:28)
@orama/orama:test:     at maybeClose (node:internal/child_process:1105:16)
@orama/orama:test:     at ChildProcess._handle.onexit (node:internal/child_process:305:5) {
@orama/orama:test:   code: 'ERR_INVALID_ARG_TYPE'
@orama/orama:test: }
@orama/orama:test:
@orama/orama:test: Node.js v21.2.0
@orama/plugin-parsedoc:test: node:internal/errors:513
@orama/plugin-parsedoc:test:       throw error;
@orama/plugin-parsedoc:test:       ^
@orama/plugin-parsedoc:test:
@orama/plugin-parsedoc:test: TypeError [ERR_INVALID_ARG_TYPE]: The "code" argument must be of type number. Received type string ('128SIGINT')
@orama/plugin-parsedoc:test:     at process.set [as exitCode] (node:internal/bootstrap/node:123:9)
@orama/plugin-parsedoc:test:     at ChildProcess.<anonymous> (/mnt/c/Workspace/open-source/orama/node_modules/.pnpm/[email protected]/node_modules/foreground-child/index.js:63:22)
@orama/plugin-parsedoc:test:     at ChildProcess.emit (node:events:519:28)
@orama/plugin-parsedoc:test:     at maybeClose (node:internal/child_process:1105:16)
@orama/plugin-parsedoc:test:     at ChildProcess._handle.onexit (node:internal/child_process:305:5) {
@orama/plugin-parsedoc:test:   code: 'ERR_INVALID_ARG_TYPE'
@orama/plugin-parsedoc:test: }
@orama/plugin-parsedoc:test:
@orama/plugin-parsedoc:test: Node.js v21.2.0

mbianchidev avatar Dec 04 '23 00:12 mbianchidev