aseba icon indicating copy to clipboard operation
aseba copied to clipboard

Dependencies Cleaning

Open cor3ntin opened this issue 7 years ago • 5 comments

There is a number of dependencies we could get rid of or replace, given the occasion

  • libxml2 => QtXml
  • SDL2 => QtGamepad ( since Qt 5.7 )
  • QWT => QtCharts ( since Qt 5.7 )

cor3ntin avatar Jan 24 '18 17:01 cor3ntin

No, then that introduces a dependency on Qt that is not needed for many products. Asebahttp uses libxml2, Asebacompiler.js uses the SDL provided by Emscripten.

I feel like I am repeating myself, I said essentially the same thing in https://github.com/aseba-community/aseba/issues/793#issuecomment-360063972!

davidjsherman avatar Jan 24 '18 17:01 davidjsherman

I agree with David, libxml2 is a lower-level library that is well suited for embedded, and SDL2 is also much smaller than Qt and more suitable for command-line tools.

I'm fine with getting ride of Qwt if QtCharts brings similar features or better, but as it currently works well, I do not see the value of changing as there is non-trivial code rewrite to do. Do we have a comparison of the two feature-wise?

stephanemagnenat avatar Jan 24 '18 19:01 stephanemagnenat

My argument was that if Qt is already installed, QChart is more likely to be installed to. especially on Mac and Windows

I don't have a comparison but I think QChart would be a suitable replacement considering the use we have of it.
https://doc.qt.io/qt-5.10/qtcharts-overview.html

cor3ntin avatar Jan 24 '18 19:01 cor3ntin

Marcel Dassault reputedly said that when designing a new version of an airplane, you change the flight surfaces, the motor, the weapons — but for each model, change only one at a time. My strong recommendation is that, if you must redo the build system, then do only that. Make it functionally equivalent to the old one, test it to make sure that there are no regressions, send it out for beta test and sit on it for a week.

If it works and is accepted, then it will be possible to leverage it to add new features.

davidjsherman avatar Jan 24 '18 20:01 davidjsherman

I was not suggesting to do that now.

cor3ntin avatar Jan 24 '18 20:01 cor3ntin