Asbjorn Enge

Results 38 comments of Asbjorn Enge

By changing this line in `test/spec.js` ``` js var spinnerRaw = fs.readFileSync('./test/spinner.gif','base64') ``` to ``` js var _spinnerRaw = fs.readFileSync('./test/spinner.gif','utf-8') var spinnerRaw = new Buffer(_spinnerRaw).toString('base64') ``` I can make the...

Simplified the code quite a bit :stuck_out_tongue_closed_eyes: I'm going to take 1 more shot at figuring out that buffer issue tomorrow. If I can't I'll release as it is now.

Alright, no luck :disappointed: So I went ahead and released the rewrite as a new major version [2.0.0](https://www.npmjs.com/package/imgurify) :tada: I also opened and issue [here](https://github.com/substack/node-browserify/issues/1545) in hope for some help...

Interesting... Looking at the [spec](http://tools.ietf.org/html/rfc2397): ``` The appearance of ";base64" means that the data is encoded as base64. Without ";base64", the data (as a sequence of octets) is represented using...

Hmmm... I wonder if `encodeURIComponent` makes sense only if I don't pass the charset...? I'll make a quick `browsertest` to make it easier to check out in browsers...

@oros alright, so... totally forgot to branch off :stuck_out_tongue_closed_eyes: but in latest master I've removed the encoding and set the `charset=utf8` correctly for the svg. Could you give it a...

@oros that's so weird! I was originally using [budo](https://github.com/mattdesl/budo) to run the `testapp`, and I got that exact same broken output for the raster images. Eventually tried without `budo` and...

@oros Yeah, it's a weird one :stuck_out_tongue: Anyway, I'll just leave this issue open until I have time to figure it out, or in case someone else comes along with...

Well we can atleast make a note that the raster issue is related to #4 and versions of browserify > 11.2.0 :smile:

Would gladly support if you can build us a PR 👍