nginx-rtmp-module icon indicating copy to clipboard operation
nginx-rtmp-module copied to clipboard

Integration of Timed Metadata for HLS

Open git-audo opened this issue 4 years ago • 4 comments

Hi, I worked on the support for HLS timed metadata as described in the Apple documentation [0]. Since the metadata is required to be in the ID3 format, I included a third party library [1] for the handling of this structure. If this could be of some interest it'd be great to know. I'd really appreciate a review of the added code, if someone has the time to do it. Thank you and good work!

[0] https://developer.apple.com/library/archive/documentation/AudioVideo/Conceptual/HTTP_Live_Streaming_Metadata_Spec/Introduction/Introduction.html [1] https://github.com/larsbs/id3v2lib

git-audo avatar Dec 14 '20 20:12 git-audo

Is this pullrequest working properly? When I tried, have an errror that it couldn't find id3v2lib, Is it solved by just adding the library?

SeungSeoChoi avatar Oct 06 '21 07:10 SeungSeoChoi

Bump, will this ever be added into the main branch?

ssamjh avatar May 19 '22 12:05 ssamjh

Never

frics avatar May 19 '22 12:05 frics

I would say no, the last PR that was merged to master dates 5 years ago. Also when I wrote this code I still had a lot to learn, the quality of this implementation is not really that great. It would definitely need a rework.

git-audo avatar May 20 '22 17:05 git-audo