gnome-command-menu icon indicating copy to clipboard operation
gnome-command-menu copied to clipboard

GNOME 46 Support

Open kzhe2059 opened this issue 1 year ago • 12 comments

Support for GNOME 46 isn't present

kzhe2059 avatar Mar 27 '24 21:03 kzhe2059

Yeah I haven't maintained it in a while.

arunk140 avatar Mar 28 '24 00:03 arunk140

There was a fork in the extensions website. It was compatible with GNOME 45, but it appears to be deleted now. I have the .zip here. It's also compatible with 46.

diegopvlk avatar Apr 04 '24 13:04 diegopvlk

There was a fork in the extensions website. It was compatible with GNOME 45, but it appears to be deleted now. I have the .zip here. It's also compatible with 46.

@diegopvlk

i used that same fork for gnome 45, today i upgraded to gnome 46 then tried edditing metadata.json by adding 46 but didn't work until i saw ur comment, downloaded the zip and placed it in the right location and it works!

my question what did u modify in the extension files ? and u have an idea why the fork got removed ?

molitona avatar Apr 04 '24 17:04 molitona

i see the hack @diegopvlk

Screenshot from 2024-04-04 18-13-06

how u figured that out ?

molitona avatar Apr 04 '24 17:04 molitona

Yeah I haven't maintained it in a while.

@arunk140 can u just update it with @diegopvlk zip which works perfectly on gnome 46 ?

molitona avatar Apr 04 '24 17:04 molitona

how u figured that out ?

I actually didn't remember that I had fixed it 😅 but I just checked the logs, that's about it

diegopvlk avatar Apr 04 '24 17:04 diegopvlk

how u figured that out ?

I actually didn't remember that I had fixed it 😅 but I just checked the logs, that's about it

you did the only diff between my version on 45 and ur fixed one is this method "add_child" instead of "add"

how u checked extensions logs ?

molitona avatar Apr 05 '24 09:04 molitona

how u checked extensions logs ?

journalctl -f -o cat /usr/bin/gnome-shell

diegopvlk avatar Apr 05 '24 12:04 diegopvlk

Would someone like to push a PR so that @arunk140 can approve?

jasonm23 avatar Apr 15 '24 04:04 jasonm23

@joostn maybe this can be added into your existing PR? https://github.com/arunk140/gnome-command-menu/pull/13

jasonm23 avatar Apr 15 '24 04:04 jasonm23

I've opened a PR, I hope it can be included?

In the mean time you can use my fork as follows:

cd /tmp
git clone --branch gnome45 https://github.com/joostn/gnome-command-menu.git
cd gnome-command-menu
gnome-extensions pack --force
gnome-extensions install [email protected] --force
# and restart gnome

joostn avatar Apr 15 '24 05:04 joostn