adblock-detect-react icon indicating copy to clipboard operation
adblock-detect-react copied to clipboard

Published 20 hours ago • verified publisher icon aruniverse

Package not detecting Brave shields ad blocker

Open rickstaa opened this issue 2 years ago • 6 comments

Describe the bug

It seems that the package currently does not detect when ads are blocked using brave shields.

To Reproduce

Steps to reproduce the behaviour:

  1. Go to https://adblock-detect-react.vercel.app/ using a brave browser.
  2. Enable brave shields.
  3. See the ad blocker not being detected.

Expected behaviour

The brave shields adblocker should be detected.

Please complete the following information:

Additional context

I tried to find a way to detect when ad blocking is enabled in brave but could not yet find a way. There seems to be a bold object on the navigator, but it doesn't contain any shield information (see https://github.com/brave/brave-browser/issues/10165#issuecomment-641128278).

rickstaa avatar Feb 16 '23 11:02 rickstaa

It looks like it's not working for any browsers I'm using. I get the same output no matter what with and without ad blocking running.

ImLunaHey avatar Feb 18 '23 08:02 ImLunaHey

Screen Shot 2023-02-18 at 7 14 12 pm

ImLunaHey avatar Feb 18 '23 08:02 ImLunaHey

Screen Shot 2023-02-18 at 7 14 12 pm

Thanks for the report. Which blocker are you using? It seems to work for Ublockplus on chrome:

image

rickstaa avatar Feb 18 '23 09:02 rickstaa

Also does not detect uBlock Origin using any browser

Wamy-Dev avatar Mar 06 '23 22:03 Wamy-Dev

Don't fall for this 🙏

DisabledMallis avatar Jan 01 '24 19:01 DisabledMallis

I reported this to GitHub.

Hopefully the maintainer of this repo takes down the issue

Mohagames205 avatar Jan 01 '24 19:01 Mohagames205