Artur Müller comments

Results 28 comments of


                                            Artur Müller

Fix mask() working incorrectly with union() when an alternative object contains extra unknown props

Hi @dimikot — please lmk if you would like to finish this PR. 🙏

Fix mask() working incorrectly with union() when an alternative object contains extra unknown props

@dimikot — thank you for your work on this. I've merged it into `main` in a separate PR as I wasn't able to make changes in your branch, but your...

Fix compatibility with Node16/NodeNext moduleResolution

@nerochiaro The TS error actually explains it correctly — you are importing an ECMAScript module (`superstruct` in this case) from a CommonJS module. That's currently not allowed by Node.js. The...

Fix compatibility with Node16/NodeNext moduleResolution

This has been resolved in 2.0!

[Feature] Support for `Required`

Makes sense to me! Very open to a PR if anyone wants to take this on.

Module resolution, switched testing to vitest

Hi @ciscoheat — thank you so much for this PR — it is hugely appreciated! 🎉 Getting Superstruct to be compatible with NodeNext is my priority right now (I have...

Module resolution, switched testing to vitest

Thank you for getting this off the ground @ciscoheat — I am closing this PR since we solved it in another PR, but your work on this is still super...

Compatibility with moduleResolution: "Node16" is broken.

Closing in this favour of #1200 (it is currently my priority to fix this).

Expose generator validation

@ritave could you perhaps define your struct via `new Struct()`? I guess it is not exactly public API, but given that it is used all around the superstruct codebase, I...

Expose generator validation

Yeah, that is a good point (and probably a wise approach!). @ianstormtaylor I wonder if it would make sense to publicly document the Struct class? People might want to use...