fastapi-filter icon indicating copy to clipboard operation
fastapi-filter copied to clipboard

feat: Support SQLModel

Open bartelemi opened this issue 2 years ago • 11 comments

I'd like to raise a request for supporting SQLModel library integration.

It should be a relatively straightforward implementation, as SQLModel is based on SQLAlchemy and this lib already has that integration. It would be amazing if the type-safety and generic Select/Query types were supported.

Similar library from the FastAPI ecosystem support it already: https://github.com/uriyyo/fastapi-pagination

I'm happy to raise a pull-request at some point, but I'm submitting this issue to spin up some discussion.

bartelemi avatar Jan 10 '23 19:01 bartelemi

Just like for tortoise support, I don't personally use SQLModel (yet) so a PR would be appreciated. If I start playing with SQLModel I'll probably do it myself but it's not in my current plans.

arthurio avatar Jan 11 '23 05:01 arthurio

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar Jan 06 '24 05:01 github-actions[bot]

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar Mar 07 '24 01:03 github-actions[bot]

No, not stale please

joshTax avatar Mar 07 '24 01:03 joshTax

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar May 07 '24 01:05 github-actions[bot]

Keepalive

joshTax avatar May 07 '24 03:05 joshTax

I'm not sure this is still an issue. I just got done implementing my first filter with fastapi-filter using SQLModel. I just pointed it at my main SQLModel, the one with table=True, and it worked fine.

I'd be curious to hear if others have hit any issues trying this?

jlantz avatar May 13 '24 22:05 jlantz

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar Jul 13 '24 01:07 github-actions[bot]

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar Sep 12 '24 02:09 github-actions[bot]