recursive-code-config icon indicating copy to clipboard operation
recursive-code-config copied to clipboard

Script throws an error when all of the config Features are turned off

Open mapadev opened this issue 4 years ago • 3 comments

When running the script with all Features turned off in config.yaml, the script throws:

line 226, in <module>
    splitFont()
line 151, in splitFont
    pyftfeatfreeze.main([f"--features=rvrn,{','.join(fontOptions['Features'])}", outputPath, outputPath])
TypeError: can only join an iterable

mapadev avatar Feb 23 '21 12:02 mapadev

I think this happens due to an incompatible YAML file in that case, rather than a bug in the script. If you want to turn off all features you can specify an empty array in YAML like this:

Features: []

jwortmann avatar Feb 26 '21 01:02 jwortmann

My thanks to both of you!

@mapadev, I appreciate the issue. I'll make the script handle this situation more gracefully before closing the issue.

@jwortmann thanks for the suggestion! I haven't tested it yet, but that does seem like a promising workaround until I can get to fixing this in a better way. @mapadev if you want to try it, please let me know if it works!

arrowtype avatar Feb 26 '21 01:02 arrowtype

@arrowtype. The provided solution works for me as I just wanted to try some general settings without embedding any specific features.

Thank you @jwortmann.

mapadev avatar Mar 02 '21 19:03 mapadev

Thanks so much for solving this, @jwortmann! I have added your helpful suggestion to the readme.

arrowtype avatar Apr 12 '23 01:04 arrowtype