django-ledger icon indicating copy to clipboard operation
django-ledger copied to clipboard

Change in template to make months dropdown option

Open rkisdp opened this issue 3 years ago • 5 comments

Changed the month paragraph tag to the dropdown option, it gives it a better view.

Now it looks like this Screenshot (61) Screenshot (62)

before it used to look like this Screenshot (63)

rkisdp avatar Jul 11 '22 09:07 rkisdp

Hi @elarroba, Please review the PR. I have just changed the month paragraph tag to a dropdown. I am trying to fix test cases and commit them to another branch after you merge this branch. Please let me know if you want me to add, remove or change something in this PR. Thanks!

rkisdp avatar Jul 11 '22 09:07 rkisdp

@rkisdp thank you for your Pull Request. Happy to accept your contribution, However in order to keep things consistent with the CSS framework (Bulma), please look at the documentation to style the select input properly.

https://bulma.io/documentation/form/select/

elarroba avatar Jul 11 '22 15:07 elarroba

Got it, Bulma is new for me, honestly, I have never heard of this, I will go through it and commit the changes again. Thanks!

rkisdp avatar Jul 11 '22 18:07 rkisdp

Hi, @elarroba, I tried several classes of bulma, but none of them were looking nice, so I didn't add any styling class in div. Please help me understand how can I use bulma styling here?

rkisdp avatar Jul 17 '22 15:07 rkisdp

Hi @elarroba, any review or feedback on this?

rkisdp avatar Jul 23 '22 20:07 rkisdp