go-metrics icon indicating copy to clipboard operation
go-metrics copied to clipboard

Apply the same logic to all metric type for Hostname prefixing

Open uepoch opened this issue 7 years ago • 4 comments

Use EnableHostname boolean in all types of metrics instead of just gauges

uepoch avatar Sep 07 '18 13:09 uepoch

hello @banks ! Just added tests, ready to go from my POV

uepoch avatar Sep 24 '18 09:09 uepoch

Do you need any more information ?

uepoch avatar Nov 12 '18 16:11 uepoch

Hello @banks, sorry for HLing again :( , did you had the time to look at this review ?

Should I remove the safeguard ?

uepoch avatar Jan 21 '19 16:01 uepoch

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes


m.conraux seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you already have a GitHub account, please add the email address used for this commit to your account.

Have you signed the CLA already but the status is still pending? Recheck it.

hashicorp-cla avatar Sep 30 '22 21:09 hashicorp-cla