go-metrics icon indicating copy to clipboard operation
go-metrics copied to clipboard

ignore feature using syscall for appengine users

Open tutuming opened this issue 8 years ago • 4 comments

for #38

go-metrics is imported from goa ( https://github.com/goadesign/goa ) and some users (including me) use appengine to serve APIs.

Build for appengine failed because import of syscall package is not allowed. So for the appengine users, ignoring the InmemSignal feature make them happy.

tutuming avatar Feb 14 '17 02:02 tutuming

I hope this request will be merged soon

pei0804 avatar Mar 29 '17 14:03 pei0804

This seems fine to me. Can you also add a note to the README that the InmemSignal is not supported on this platform?

ryanuber avatar Mar 29 '17 17:03 ryanuber

Go-app-builder: Failed parsing input: parser: bad import "syscall" in ... This problem is a problem occurring in GAE which is PaaS of GCP. Two packages, syscall and unsafe, are not allowed to be used on GAE. So, you need a description not included in the build.

The target files are as follows.

  • const_unix.go
  • const_windows.go
  • inmem_signal.go
  • inmem_signal_test.go

We have created a request. Verification please. https://github.com/armon/go-metrics/pull/47

pei0804 avatar Mar 30 '17 01:03 pei0804

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

Have you signed the CLA already but the status is still pending? Recheck it.

hashicorp-cla avatar Sep 30 '22 21:09 hashicorp-cla