Ari Stathopoulos

Results 197 comments of Ari Stathopoulos
trafficstars

Block styles in particular don't have any media-queries in them, so they can be plain CSS file... :thinking: Maybe these files could be pulled-out of the compiling process and just...

Compiled the blocks sass files to css and removed them - as well as their build process.

@joyously that's why yesterday we had a 90-minute meeting, where we discussed things. There were no objections from anyone, so it was decided to move forward with this. If you...

The concern is that we limit things too much, and as a result authors will keep finding ways to circumvent the checks. They were not allowed to add a top-level...

Why should it handle them? Changing units when the value is `0` doesn't really change anything... `0px` is the same as `0%` and `0em` :thinking:

Agreed. It could be a-la-[react-select](https://react-select.com/home) which would accept custom values too, but it should primarily work as a select input :+1:

All themes go through a manual review once they get uploaded to the repo. Nothing goes live without first being reviewed, and this theme-check is just the 1st step in...

The problem here is that we check if `wp_title` is contained, and `oceanwp_title` contains `wp_title`. Ideally we'd look for exact word matches, so using a regex function that would be...

Should the check be removed, or tweaked? Tweaking it should be relatively easy and changing the line highlighted above to this should do it: ```php if ( preg_match( '/\bwp_title\b/', $file_content...