notifications-engine
notifications-engine copied to clipboard
fix: Ignore 422 response while creating commit statuses
Ignore HTTP 422 responses by GitHub while trying to create commit statuses. GitHub limits creating commit statuses to 1000 attempts with the same SHA and context. Currently, when the limit is reached, Argo CD notification controller keeps retrying needlessly which wastes resources. Instead, the notification engine should give up on retrying and signal the caller that the notification attempt has been processed.
@pasha-codefresh, can you review it?
Hey-hey. @pasha-codefresh, any updates?
Hi @pasha-codefresh, I hope you're doing well! It's been over six months since the proposed change was shared. Do you happen to see any issues with it?
@ragnarpa Taking a look