notifications-engine icon indicating copy to clipboard operation
notifications-engine copied to clipboard

fix: Ignore 422 response while creating commit statuses

Open ragnarpa opened this issue 1 year ago • 4 comments
trafficstars

Ignore HTTP 422 responses by GitHub while trying to create commit statuses. GitHub limits creating commit statuses to 1000 attempts with the same SHA and context. Currently, when the limit is reached, Argo CD notification controller keeps retrying needlessly which wastes resources. Instead, the notification engine should give up on retrying and signal the caller that the notification attempt has been processed.

ragnarpa avatar May 21 '24 19:05 ragnarpa

@pasha-codefresh, can you review it?

ragnarpa avatar May 31 '24 10:05 ragnarpa

Hey-hey. @pasha-codefresh, any updates?

ragnarpa avatar Jul 15 '24 07:07 ragnarpa

Hi @pasha-codefresh, I hope you're doing well! It's been over six months since the proposed change was shared. Do you happen to see any issues with it?

ragnarpa avatar Jan 06 '25 13:01 ragnarpa

@ragnarpa Taking a look

pasha-codefresh avatar Feb 23 '25 18:02 pasha-codefresh