notifications-engine icon indicating copy to clipboard operation
notifications-engine copied to clipboard

fix(ci): Download Go modules before linting to resolve TypeCheck errors

Open adamdmharvey opened this issue 1 year ago • 2 comments
trafficstars

Noticed some reports on TypeCheck errors in https://github.com/golangci/golangci-lint-action/issues/902. These are similar to what we see with https://github.com/argoproj/notifications-engine/pull/256, https://github.com/argoproj/notifications-engine/pull/255, and https://github.com/argoproj/notifications-engine/pull/254.

The linter in v1.54 seemed to deprecate some of the TypeChecking errors, and so I've bumped the linter up also (which seemed to fix the problem).

adamdmharvey avatar Jan 08 '24 18:01 adamdmharvey

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (c02dc5f) 55.13% compared to head (2779b52) 55.13%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #257   +/-   ##
=======================================
  Coverage   55.13%   55.13%           
=======================================
  Files          35       35           
  Lines        3337     3337           
=======================================
  Hits         1840     1840           
  Misses       1230     1230           
  Partials      267      267           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 08 '24 19:01 codecov[bot]

Looks like it is working now, should we close the PR?

pasha-codefresh avatar Feb 01 '24 17:02 pasha-codefresh