notifications-engine icon indicating copy to clipboard operation
notifications-engine copied to clipboard

feat(github) add support for GitHub deployment reference

Open carloscastrojumo opened this issue 2 years ago • 4 comments
trafficstars

As it is, the revision that triggered the deployment is used as the ref, however it is useful to override so we can pass a tag, a branch or a different SHA.

Example:

Screenshot 2023-10-02 at 20 32 00

carloscastrojumo avatar Oct 02 '23 19:10 carloscastrojumo

Codecov Report

Attention: Patch coverage is 26.66667% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 55.35%. Comparing base (ec7fcb4) to head (69e2e96).

Files Patch % Lines
pkg/services/github.go 26.66% 9 Missing and 2 partials :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #225      +/-   ##
==========================================
- Coverage   55.47%   55.35%   -0.13%     
==========================================
  Files          35       35              
  Lines        3425     3438      +13     
==========================================
+ Hits         1900     1903       +3     
- Misses       1248     1256       +8     
- Partials      277      279       +2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Oct 02 '23 19:10 codecov[bot]

Thank you, could you please update documentation about this option? Also could you please add test for this parameter ?

@carloscastrojumo

pasha-codefresh avatar Oct 18 '23 10:10 pasha-codefresh

Hi @pasha-codefresh . I have updated the documentation about this option. Regarding the test for this parameter, I have included in the TestGetTemplater_GitHub_Deployment test.

To actually test the send message, it requires some mock setup that is currently not defined yet and Im afraid Im not enough go test knowledge to implement the skeleton.

carloscastrojumo avatar Nov 02 '23 23:11 carloscastrojumo

@pasha-codefresh any news on this please?

carloscastrojumo avatar Nov 21 '23 16:11 carloscastrojumo

Sorry @carloscastrojumo , could you please fix conflicts and i will merge it

pasha-codefresh avatar Feb 25 '24 17:02 pasha-codefresh

Done @pasha-codefresh :)

carloscastrojumo avatar Mar 01 '24 10:03 carloscastrojumo

Thank you!

pasha-codefresh avatar Mar 02 '24 17:03 pasha-codefresh