notifications-engine
notifications-engine copied to clipboard
feat: Matrix integration
Matrix is an open, federated messaging platform: https://matrix.org
ArgoCD Notifications would benefit greatly from Matrix support because a growing number of communities use it daily. Additionally, Matrix has interoperability with many other messaging platforms via bridges, which would give ArgoCD indirect support for notifications to those platforms:
- Rocket.Chat https://matrix.org/blog/2022/05/30/welcoming-rocket-chat-to-matrix
- Gitter https://matrix.org/blog/2020/12/07/gitter-now-speaks-matrix
- IRC https://matrix.org/bridges/#irc
A full list of bridges can be found at https://matrix.org/bridges
Signed-off-by: David Florness [email protected]
Codecov Report
Patch coverage: 7.36% and project coverage change: -1.40 :warning:
Comparison is base (
3446d4a) 53.53% compared to head (47e79a1) 52.13%.
Additional details and impacted files
@@ Coverage Diff @@
## master #106 +/- ##
==========================================
- Coverage 53.53% 52.13% -1.40%
==========================================
Files 34 35 +1
Lines 3026 3113 +87
==========================================
+ Hits 1620 1623 +3
- Misses 1166 1249 +83
- Partials 240 241 +1
| Impacted Files | Coverage Δ | |
|---|---|---|
| pkg/api/config.go | 47.74% <0.00%> (-3.22%) |
:arrow_down: |
| pkg/services/matrix.go | 0.00% <0.00%> (ø) |
|
| pkg/services/services.go | 26.54% <0.00%> (-0.78%) |
:arrow_down: |
| pkg/cmd/template.go | 61.94% <63.63%> (-1.27%) |
:arrow_down: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
@edwargix could you please solve merge conflicts?
@edwargix could you please solve merge conflicts?
Sure thing; just rebased: matrix.pr-0..matrix.pr-1
looks like https://github.com/argoproj/notifications-engine/pull/128 was just merged; will rebase again...
rebased: matrix.pr-1..matrix.pr-2
moved indirect dependencies to correct location: matrix.pr-2..matrix.pr-3
Thanks @edwargix , going to review this one
rebased: matrix.pr-4..matrix.pr-5
rebased: matrix.pr-5..matrix.pr-6
rebased: matrix.pr-6..matrix.pr-7
Will take a look today a bit later
rebased: matrix.pr-7..matrix.pr-8
rebased: matrix.pr-8..matrix.pr-9
@pasha-codefresh let me know if there's anything I can do to help
rebased: matrix.pr-9..matrix.pr-10
rebased: matrix.pr-10..matrix.pr-11
rebased: matrix.pr-11..matrix.pr-12
rebased: matrix.pr-12..matrix.pr-13
rebased: matrix.pr-13..matrix.pr-14