notifications-engine icon indicating copy to clipboard operation
notifications-engine copied to clipboard

chore: update deps

Open emirot opened this issue 3 years ago • 1 comments
trafficstars

Why

The go version used in test is different https://github.com/argoproj/notifications-engine/blob/master/.github/workflows/ci.yaml#L14

emirot avatar Aug 30 '22 01:08 emirot

Codecov Report

Base: 49.38% // Head: 49.00% // Decreases project coverage by -0.38% :warning:

Coverage data is based on head (60d8096) compared to base (edbd2d4). Patch has no changes to coverable lines.

:exclamation: Current head 60d8096 differs from pull request most recent head 454faa4. Consider uploading reports for the commit 454faa4 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #102      +/-   ##
==========================================
- Coverage   49.38%   49.00%   -0.39%     
==========================================
  Files          31       31              
  Lines        1873     1855      -18     
==========================================
- Hits          925      909      -16     
  Misses        746      746              
+ Partials      202      200       -2     
Impacted Files Coverage Δ
pkg/controller/controller.go 52.38% <0.00%> (-3.18%) :arrow_down:
pkg/services/googlechat.go 60.71% <0.00%> (-1.45%) :arrow_down:
pkg/services/webhook.go 67.24% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Aug 30 '22 02:08 codecov[bot]

@emirot please solve merge conflicts

pasha-codefresh avatar Nov 28 '22 20:11 pasha-codefresh

https://github.com/argoproj/notifications-engine/pull/120

emirot avatar Nov 29 '22 04:11 emirot