Allow user to skip verification on self-signed certs

[jocelynthode]

trafficstars

The generic webhook is hardcoded to not skip insecure. I would like to be able to specify this as a webhook option.

[codecov[bot]]

Codecov Report

Base: 49.38% // Head: 49.17% // Decreases project coverage by -0.21% :warning:

Coverage data is based on head (8b26b94) compared to base (b36d196). Patch coverage: 100.00% of modified lines in pull request are covered.

:exclamation: Current head 8b26b94 differs from pull request most recent head a8440c4. Consider uploading reports for the commit a8440c4 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #100      +/-   ##
==========================================
- Coverage   49.38%   49.17%   -0.22%     
==========================================
  Files          31       31              
  Lines        1873     1873              
==========================================
- Hits          925      921       -4     
- Misses        746      749       +3     
- Partials      202      203       +1     

Impacted Files	Coverage Δ
pkg/services/webhook.go	67.24% <100.00%> (ø)
pkg/controller/controller.go	52.38% <0.00%> (-3.18%)	:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

[pasha-codefresh]

@jocelynthode could you please mention such an option in the documentation?

[jocelynthode]

@pasha-codefresh : Oh wow, I had completely forgotten about this PR! Glad it's getting some attention :)

I have added documentation for the generic webhook as well as added the option to be used in the tests.

Let me know if I need to do something else

[pasha-codefresh]

Great job @jocelynthode , thank you

[pasha-codefresh]

Please not forget update it in argocd

[jocelynthode]

What do you mean? should I do something more to have this feature land in argocd?

[pasha-codefresh]

This package used in argocd as dependency, you beed also update it here